Refactor dev tool console to use opensearch-js client to send request #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3544 +/- ##
==========================================
- Coverage 66.41% 66.40% -0.02%
==========================================
Files 3209 3208 -1
Lines 61617 61593 -24
Branches 9504 9502 -2
==========================================
- Hits 40926 40902 -24
+ Misses 18412 18410 -2
- Partials 2279 2281 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
zhongnansu
force-pushed
the
md-dev-tool
branch
3 times, most recently
from
a1a30de to
13c5c57
Compare
zhongnansu
changed the title
zhongnansu
changed the title
kristenTian
reviewed
Mar 14, 2023
AMoo-Miki
reviewed
Mar 14, 2023
src/plugins/console/server/routes/api/console/proxy/create_handler.ts
Outdated
Show resolved
Hide resolved
AMoo-Miki
reviewed
Mar 14, 2023
src/plugins/console/server/routes/api/console/proxy/create_handler.ts
Outdated
Show resolved
Hide resolved
AMoo-Miki
reviewed
Mar 14, 2023
src/plugins/console/server/routes/api/console/proxy/create_handler.ts
Outdated
Show resolved
Hide resolved
AMoo-Miki
reviewed
Mar 14, 2023
src/plugins/console/server/routes/api/console/proxy/create_handler.ts
Outdated
Show resolved
Hide resolved
kristenTian
reviewed
Mar 14, 2023
kristenTian
previously approved these changes
Mar 14, 2023
kristenTian
previously approved these changes
Mar 15, 2023
abbyhu2000
reviewed
Mar 20, 2023
src/plugins/console/server/routes/api/console/proxy/tests/query_string.test.ts
Show resolved
Hide resolved
src/plugins/console/server/routes/api/console/proxy/tests/proxy_fallback.test.ts
Show resolved
Hide resolved
src/plugins/console/server/routes/api/console/proxy/create_handler.ts
Outdated
Show resolved
Hide resolved
abbyhu2000
reviewed
Mar 20, 2023
src/plugins/console/server/routes/api/console/proxy/tests/params.test.ts
Show resolved
Hide resolved
…ith OpenSearch - Update tests Signed-off-by: Su <[email protected]>
Signed-off-by: Su <[email protected]>
Signed-off-by: Su <[email protected]>
abbyhu2000
approved these changes
Mar 20, 2023
kristenTian
approved these changes
Mar 21, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
…#3544) Refactor dev tool console to use opensearch-js client to interact with OpenSearch Signed-off-by: Su <[email protected]> (cherry picked from commit de06344) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
kappassov
pushed a commit
to kappassov/OpenSearch-Dashboards
that referenced
this pull request
Mar 21, 2023
…opensearch-project#3544) Refactor dev tool console to use opensearch-js client to interact with OpenSearch Signed-off-by: Su <[email protected]>
zhongnansu
added a commit
that referenced
this pull request
Mar 21, 2023
…to send request (#3639) * Refactor dev tool console to use opensearch-js client to send request (#3544) Refactor dev tool console to use opensearch-js client to interact with OpenSearch Signed-off-by: Su <[email protected]> (cherry picked from commit de06344) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md * add changelog Signed-off-by: Su <[email protected]> --------- Signed-off-by: Su <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Su <[email protected]>
pjfitzgibbons
pushed a commit
to pjfitzgibbons/OpenSearch-Dashboards
that referenced
this pull request
Mar 22, 2023
…opensearch-project#3544) Refactor dev tool console to use opensearch-js client to interact with OpenSearch Signed-off-by: Su <[email protected]>
abbyhu2000
pushed a commit
that referenced
this pull request
Mar 22, 2023
…3633) * added prepare command Signed-off-by: kappassov <[email protected]> * Use mirrors to download Node.js binaries to escape sporadic 404 errors (#3619) Issue Resolved: #3618 Signed-off-by: Anan Zhuang <[email protected]> * Allow selecting the Node.js binary OSD uses (#3508) New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD. * The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary. * Update `package.json` to replace `node` with `use_node`. * Update file templates and shell scripts to internally use `use_node`. * Update the build scripts to copy `use_node` into releases * Make tests that execute node internally, honor the binary being used. Signed-off-by: Miki <[email protected]> * Clean up and rebuild @osd/pm (#3570) * Fix the build failures * Removed some unused packages * Update gist url templates in Lychee's exclusion list Signed-off-by: Miki <[email protected]> * Refactor dev tool console to use opensearch-js client to send request (#3544) Refactor dev tool console to use opensearch-js client to interact with OpenSearch Signed-off-by: Su <[email protected]> * updates after the 1st review Signed-off-by: kappassov <[email protected]> --------- Signed-off-by: kappassov <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Su <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Zhongnan Su <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 22, 2023
…3633) * added prepare command Signed-off-by: kappassov <[email protected]> * Use mirrors to download Node.js binaries to escape sporadic 404 errors (#3619) Issue Resolved: #3618 Signed-off-by: Anan Zhuang <[email protected]> * Allow selecting the Node.js binary OSD uses (#3508) New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD. * The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary. * Update `package.json` to replace `node` with `use_node`. * Update file templates and shell scripts to internally use `use_node`. * Update the build scripts to copy `use_node` into releases * Make tests that execute node internally, honor the binary being used. Signed-off-by: Miki <[email protected]> * Clean up and rebuild @osd/pm (#3570) * Fix the build failures * Removed some unused packages * Update gist url templates in Lychee's exclusion list Signed-off-by: Miki <[email protected]> * Refactor dev tool console to use opensearch-js client to send request (#3544) Refactor dev tool console to use opensearch-js client to interact with OpenSearch Signed-off-by: Su <[email protected]> * updates after the 1st review Signed-off-by: kappassov <[email protected]> --------- Signed-off-by: kappassov <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Su <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Zhongnan Su <[email protected]> (cherry picked from commit b0146e7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
abbyhu2000
pushed a commit
that referenced
this pull request
Mar 22, 2023
…3633) (#3651) * added prepare command * Use mirrors to download Node.js binaries to escape sporadic 404 errors (#3619) Issue Resolved: #3618 * Allow selecting the Node.js binary OSD uses (#3508) New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD. * The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary. * Update `package.json` to replace `node` with `use_node`. * Update file templates and shell scripts to internally use `use_node`. * Update the build scripts to copy `use_node` into releases * Make tests that execute node internally, honor the binary being used. * Clean up and rebuild @osd/pm (#3570) * Fix the build failures * Removed some unused packages * Update gist url templates in Lychee's exclusion list * Refactor dev tool console to use opensearch-js client to send request (#3544) Refactor dev tool console to use opensearch-js client to interact with OpenSearch * updates after the 1st review --------- (cherry picked from commit b0146e7) Signed-off-by: kappassov <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Su <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Zhongnan Su <[email protected]>
pjfitzgibbons
pushed a commit
to pjfitzgibbons/OpenSearch-Dashboards
that referenced
this pull request
Mar 24, 2023
…pensearch-project#3633) * added prepare command Signed-off-by: kappassov <[email protected]> * Use mirrors to download Node.js binaries to escape sporadic 404 errors (opensearch-project#3619) Issue Resolved: opensearch-project#3618 Signed-off-by: Anan Zhuang <[email protected]> * Allow selecting the Node.js binary OSD uses (opensearch-project#3508) New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD. * The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary. * Update `package.json` to replace `node` with `use_node`. * Update file templates and shell scripts to internally use `use_node`. * Update the build scripts to copy `use_node` into releases * Make tests that execute node internally, honor the binary being used. Signed-off-by: Miki <[email protected]> * Clean up and rebuild @osd/pm (opensearch-project#3570) * Fix the build failures * Removed some unused packages * Update gist url templates in Lychee's exclusion list Signed-off-by: Miki <[email protected]> * Refactor dev tool console to use opensearch-js client to send request (opensearch-project#3544) Refactor dev tool console to use opensearch-js client to interact with OpenSearch Signed-off-by: Su <[email protected]> * updates after the 1st review Signed-off-by: kappassov <[email protected]> --------- Signed-off-by: kappassov <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Su <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Zhongnan Su <[email protected]>
sikhote
pushed a commit
to sikhote/OpenSearch-Dashboards
that referenced
this pull request
Apr 24, 2023
…opensearch-project#3544) Refactor dev tool console to use opensearch-js client to interact with OpenSearch Signed-off-by: Su <[email protected]> Signed-off-by: David Sinclair <[email protected]>
sikhote
pushed a commit
to sikhote/OpenSearch-Dashboards
that referenced
this pull request
Apr 24, 2023
…pensearch-project#3633) * added prepare command Signed-off-by: kappassov <[email protected]> * Use mirrors to download Node.js binaries to escape sporadic 404 errors (opensearch-project#3619) Issue Resolved: opensearch-project#3618 Signed-off-by: Anan Zhuang <[email protected]> * Allow selecting the Node.js binary OSD uses (opensearch-project#3508) New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD. * The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary. * Update `package.json` to replace `node` with `use_node`. * Update file templates and shell scripts to internally use `use_node`. * Update the build scripts to copy `use_node` into releases * Make tests that execute node internally, honor the binary being used. Signed-off-by: Miki <[email protected]> * Clean up and rebuild @osd/pm (opensearch-project#3570) * Fix the build failures * Removed some unused packages * Update gist url templates in Lychee's exclusion list Signed-off-by: Miki <[email protected]> * Refactor dev tool console to use opensearch-js client to send request (opensearch-project#3544) Refactor dev tool console to use opensearch-js client to interact with OpenSearch Signed-off-by: Su <[email protected]> * updates after the 1st review Signed-off-by: kappassov <[email protected]> --------- Signed-off-by: kappassov <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Su <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Zhongnan Su <[email protected]> Signed-off-by: David Sinclair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor dev tool console to use opensearch-js client to send request
Issues Resolved
part of #2699
#3546
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr